chore: upgrade extract-zip for installer #34166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
semver/major
samuelmaddock
force-pushed
the
upgrade-extract-zip
branch
from
c8a8928
to
45bced7
Compare
MarshallOfSound
approved these changes
May 11, 2022
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
extract-zip@^1.0.3indirectly depends onminimist@0.0.8which is affected by CVE-2021-44906.By upgrading this package, it requires updating our minimum version of Node required by the Electron npm installer.
Followup: does CI run tests against the npm package scripts?
Checklist
npm testpassesRelease Notes
Notes: Minimum required node version to install the
electronnpm package is now >10